pekwm - #251 MaximizeOverHarbour & "Toggle HarbourHidden" incoherent behaviour

#251 MaximizeOverHarbour & "Toggle HarbourHidden" incoherent behaviour

Reported by:	Walther (wallex)	Assigned to:	Claes Nästén (pekdon)
Phase:	release-0.1.13	Component:	harbour
Type:	enhancement	Status:	new
Priority:	4: Low
Watchers:	Claes Nästén Walther

Description

Currently, when you have MaximizeOverHarbour set to "No" and you hide the harbour through the action "toggle HarbourHidden," the harbour will still be considered as "being there" (eg: when maximizing windows).

I think users would expect that, when the harbour is not visible, windows should maximize over the space the harbour normally would take, right?

This small patch solves this issue.

http://pastebin.com/kmpAEsbr

2010-06-03

Walther (wallex)

13:41:44

Uhm, I guess I'll just copy the patch contents here since my link to pastebin expired long ago.

Just add a call to updateStrutSize() at the end of Harbour::setStateHidden(StateAction sa), and then update the if condition in Harbour::updateStrutSize(void) from:

    if (! Config::instance()->isHarbourMaximizeOver()) {

to:

    if (! (Config::instance()->isHarbourMaximizeOver() || _hidden)) {

PS: I totally don't understand how to specify code fragments on this text-area. Hence the ugly patch explanation rather than pasting the contents here. :/